Skip to content

Fix example does not compile - #2

Closed
ttytm wants to merge 2 commits into
Ouri028:masterfrom
ttytm:fix/example
Closed

Fix example does not compile#2
ttytm wants to merge 2 commits into
Ouri028:masterfrom
ttytm:fix/example

Conversation

@ttytm

@ttytm ttytm commented Oct 5, 2023

Copy link
Copy Markdown
Contributor

Hey @Ouri028 👋, currently the example does not compile.

I'd like to make a suggestion that I think can be a good improvement for the lib in a separate PR, to then also finish the example PR for webview you submitted.

I think if we the simple example is fixed first, it can be easier to have it as something concrete to work with in the proposal I am thinking about.

@ttytm ttytm changed the title Fix example is a shared library Fix example does not compile Oct 5, 2023
@Ouri028

Ouri028 commented Oct 5, 2023

Copy link
Copy Markdown
Owner

Hey @Ouri028 👋, currently the example does not compile.

I'd like to make a suggestion that I think can be a good improvement for the lib in a separate PR, to then also finish the example PR for webview you submitted.

I think if we the simple example is fixed first, it can be easier to have it as something concrete to work with in the proposal I am thinking about.

Hey @ttytm 👋 ,

Thanks for the PR, I did notice that the example code is a little outdated and has a few issues, but I am currently working on a massive improvement to the library which will change the way it is currently being used. It will be much easier as well as give more options to the end user.

Here is a quick breakdown of the changes:

Checkable menu items.
Disable menu items.
C code rework for better interop with V.
Returning complete menu item structs instead of IDs (this will allow us to check conditions such as was the item checked/unchecked.

These are just some of the new features.

I will ask that you please put my PR on hold for the webview until the rework is done ☺️ .

If you are curios of the code, there is another branch "optimization" that you can browse through.

@ttytm

ttytm commented Oct 5, 2023

Copy link
Copy Markdown
Contributor Author

Okay, sounds and looks good 🙂. When the optimizations are finished and the suggestion I thought of is still applicable I can submit it then. For now I won't interfere 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants